fix(cli): show filenames in operation list#2435
Merged
nicoloboschi merged 1 commit intoJun 29, 2026
Merged
Conversation
nicoloboschi
approved these changes
Jun 29, 2026
nicoloboschi
left a comment
nicoloboschi
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — small, correct, well-tested. Verified refresh_cron:None compiles against main's generated client (nullable→Option) and missing filename deserializes to None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filenamefield through the CLI's operation list modelFilename:in prettyhindsight operations listoutput when the API provides itrefresh_cron: Noneon existing mental-model trigger requests so the CLI continues compiling against the current generated Rust client schemaContext
#2420 made file-upload operations expose the original filename on the API response so operators can identify pending or failed uploads. The CLI still converted the response into its local
Operationtype without that field, so pretty output only showed opaque operation/document IDs.While verifying the CLI tests, the current generated Rust client also required the newer nullable
refresh_cronfield onMentalModelTriggerInput; addingNonepreserves the existing CLI behavior and keeps the focused tests compiling.Tests
cargo test --manifest-path hindsight-cli/Cargo.toml --locked operation::testscargo test --manifest-path hindsight-cli/Cargo.toml --locked api::tests::test_operation_deserializecargo test --manifest-path hindsight-cli/Cargo.toml --locked api::tests::test_operation_deserialize_with_errorcargo test --manifest-path hindsight-cli/Cargo.toml --locked api::tests::test_operations_response_deserialize